Added pattern {date} and {seq} to file path in rolling sink. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR; we went down this path in the original Serilog.Sinks.RollingFile package, which is still maintained but is now deprecated. It would be interesting to see this approach developed further, but would need to be in a separate package, I don't think we want to take the current file sink in that direction. |
|
Closing this on the same basis as #263 (comment) in the interests of having the Issues and PR lists be short and clear In short: Custom naming/interval multiplier policies are a non-trivial ask that should go through a prototype/fork + feature proposal gate before people invest time in PRs, as it's very frustrating for people implementing them to end up with something that realistically won't be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You now can use
{date}and{seq}to define where date and sequence number will be stored. You can also alter date format by using{date:yyyy-MM-dd}for example.